Skip to content

add config options for db batch sizes used by triedb #3221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joshuacolvin0 merged 24 commits into from
Jan 16, 2026
Merged

add config options for db batch sizes used by triedb #3221

joshuacolvin0 merged 24 commits into from
Jan 16, 2026
+13 −1

Conversation

@magicxyyz
Copy link
Contributor

@magicxyyz magicxyyz commented May 7, 2025 •
edited by joshuacolvin0
Loading

This PR adds two new config options:

  • execution.caching.trie-cap-batch-size - batch size in bytes used in the TrieDB Cap operation (0 = use geth default)
  • execution.caching.trie-commit-batch-size - batch size in bytes used in the TrieDB Commit operation (0 = use geth default)

pulls in OffchainLabs/go-ethereum#452

resolves NIT-3204

@magicxyyz magicxyyz self-assigned this May 23, 2025
@magicxyyz magicxyyz removed their assignment May 27, 2025
@magicxyyz magicxyyz marked this pull request as ready for review May 28, 2025 12:59
@magicxyyz
Copy link
Contributor Author

magicxyyz commented May 28, 2025

assigned to @diegoximenes for review to pass the "hot potato", feel free to reassign to another reviewer :)

diegoximenes
diegoximenes previously approved these changes May 28, 2025
View reviewed changes
rauljordan
rauljordan previously approved these changes Dec 5, 2025
View reviewed changes
Copy link
Contributor

@rauljordan rauljordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to fix the geth commit

@codecov
Copy link

codecov bot commented Jan 15, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.90%. Comparing base (ad3f107) to head (5bf69b0).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #3221       +/-   ##
===========================================
- Coverage   56.98%   32.90%   -24.08%     
===========================================
  Files         462      462               
  Lines       56046    56050        +4     
===========================================
- Hits        31936    18442    -13494     
- Misses      19295    34395    +15100     
+ Partials     4815     3213     -1602

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026 •
edited
Loading

❌ 8 Tests Failed:

Tests completed Failed Passed Skipped
3915 8 3907 0
View the top 3 failed tests by shortest run time 
TestFIFOSequentialLocking
Stack Traces | 0.010s run time 
=== RUN   TestFIFOSequentialLocking
    fifo_lock_test.go:35: 
        	Error Trace:	/home/runner/work/nitro/nitro/bold/protocol/sol/fifo_lock_test.go:35
        	Error:      	Not equal: 
        	            	expected: []int{0, 1, 2, 3, 4, 5, 6, 7, 8, 9}
        	            	actual  : []int{0, 1, 3, 2, 4, 5, 6, 7, 8, 9}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -3,4 +3,4 @@
        	            	  (int) 1,
        	            	+ (int) 3,
        	            	  (int) 2,
        	            	- (int) 3,
        	            	  (int) 4,
        	Test:       	TestFIFOSequentialLocking
--- FAIL: TestFIFOSequentialLocking (0.01s)

TestDataStreaming_PositiveScenario/Many_senders,_long_messages
Stack Traces | 0.160s run time 
... [CONTENT TRUNCATED: Keeping last 20 lines]
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic.func1()
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:230 +0x14f
        created by github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic in goroutine 200
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:223 +0x85
        
    protocol_test.go:230: �[31;1m [] too much time has elapsed since request was signed �[0;0m
INFO [01-16|16:21:08.006] rpc response                             method=datastreaming_start logId=2 err="too much time has elapsed since request was signed" result={} attempt=0 args="[\"0x696a6573\", \"0x36\", \"0xd9\", \"0x2dac\", \"0xa\", \"0x7d7a6471795839655e461656cddce1854f3794e65d19599fd6d119c66b0124c520a9398860bda2d3bcf8087786c8301c8b66e4927652869dafe9a1a890a535ad00\"]" errorData=null
    protocol_test.go:230: goroutine 205 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.5/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x1569250, 0xc00015ac40}, {0x154fd00, 0xc000b1c120}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic.func1()
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:230 +0x14f
        created by github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic in goroutine 200
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:223 +0x85
        
    protocol_test.go:230: �[31;1m [] too much time has elapsed since request was signed �[0;0m
--- FAIL: TestDataStreaming_PositiveScenario/Many_senders,_long_messages (0.16s)

TestDataStreaming_PositiveScenario
Stack Traces | 0.190s run time 
=== RUN   TestDataStreaming_PositiveScenario
--- FAIL: TestDataStreaming_PositiveScenario (0.19s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Tristan-Wilson
Tristan-Wilson previously approved these changes Jan 16, 2026
View reviewed changes
@joshuacolvin0 joshuacolvin0 mentioned this pull request Jan 16, 2026
Merged
joshuacolvin0
joshuacolvin0 previously approved these changes Jan 16, 2026
View reviewed changes
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joshuacolvin0
joshuacolvin0 approved these changes Jan 16, 2026
View reviewed changes
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 added this pull request to the merge queue Jan 16, 2026
Merged via the queue into master with commit 6131880 Jan 16, 2026
25 checks passed
@joshuacolvin0 joshuacolvin0 deleted the triedb-batch-sizes branch January 16, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshuacolvin0 joshuacolvin0 joshuacolvin0 approved these changes

@diegoximenes diegoximenes diegoximenes left review comments

@rauljordan rauljordan rauljordan left review comments

@Tristan-Wilson Tristan-Wilson Tristan-Wilson left review comments

@amsanghi amsanghi Awaiting requested review from amsanghi

Assignees

@magicxyyz magicxyyz

Labels

design-approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@magicxyyz @diegoximenes @rauljordan @joshuacolvin0 @Tristan-Wilson